Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Shoutrr type for telegram notification #235

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

somtochiama
Copy link
Member

Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@@ -157,6 +158,10 @@ func (s *EventServer) handleEvent() func(w http.ResponseWriter, r *http.Request)
if t, ok := secret.Data["token"]; ok {
token = string(t)
}

if p, ok := secret.Data["port"]; ok {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the port a "secret"? The URL should contain the port if it's not 80 or 443.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take the port out

@dholbach
Copy link
Member

Best rename the file to shoutrrr.go (with 3x "r").

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants