Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement partial apply #1241

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cwrau
Copy link

@cwrau cwrau commented Sep 11, 2024

this allows the user to create for example a HelmRelease for an operator and the corresponding resource in the same commit

TODO:

  • tests
  • documentation

this allows the user to create for example a HelmRelease for an operator
and the corresponding resource in the same commit

Signed-off-by: Chris Werner Rau <cwrau@cwrau.info>
@cwrau cwrau marked this pull request as draft September 11, 2024 14:45
@cwrau
Copy link
Author

cwrau commented Sep 11, 2024

Where is the correct place to create/update documentation for this?

And, do I need to commit the updated CRDs?

@cwrau cwrau marked this pull request as ready for review September 12, 2024 15:13
@stefanprodan
Copy link
Member

This is not something that I would be in favor of, we have dependsOn which allows you to properly apply things in order.

This kind of change would require a RFC, you need to find a Flux maintainer to sponsor your proposal, see here the RFC process https://github.com/fluxcd/flux2/tree/main/rfcs.

@stefanprodan stefanprodan added the hold Issues and pull requests put on hold label Sep 12, 2024
@cwrau
Copy link
Author

cwrau commented Sep 13, 2024

This is not something that I would be in favor of, we have dependsOn which allows you to properly apply things in order.

Yes and no, dependsOn does not support this exact use-case, as that only works with different kustomizations and not within the same kustomization, which forces the user to create a second kustomization just for ordering while the ordering from a users' standpoint is more often than not just noise and more work; having to split changes into multiple commits and waiting for reconciliation or even multiple repos just for ordering is quite the nuisance, especially when dealing with more than a small handful of clusters.

This kind of change would require a RFC, you need to find a Flux maintainer to sponsor your proposal, see here the RFC process fluxcd/flux2@main/rfcs.

Huh, didn't know of that, then I suppose I'm going to copy my original issue to a discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Issues and pull requests put on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants