gitlab: drop HWLOC_COMPONENTS=x86 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: per the hwloc(7) documentation for hwloc v2.3.0, the HWLOC_COMPONENTS environment variable, if used, will override the HWLOC_XMLFILE variable. According to the docs, "since this variable is the low-level and more generic way to select components, it takes precedence over environment variables for selecting components." I don't believe we've actually hit this problem. But just in case, it seems advisable to drop the HWLOC_COMPONENTS variable in favor of using the xml file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: per the hwloc(7) documentation for hwloc v2.3.0, the HWLOC_COMPONENTS environment variable, if used, will override the HWLOC_XMLFILE variable. According to the docs, "since this variable is the low-level and more generic way to select components, it takes precedence over environment variables for selecting components."
I don't believe we've actually hit this problem. But just in case, it seems advisable to drop the HWLOC_COMPONENTS variable in favor of using the xml file.