Improved read all. #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you resolve conflicts? |
hariharan-devarajan
force-pushed
the
improve/read_all_opt
branch
from
b541a9e
to
199ceca
Compare
|
@JaeseungYeom I rebased it. There was no conflict. The branches had diverged. It should be fine now. |
Reading small 4KB chunks are very slow so replacing it by reading all data into user buffer directly.
hariharan-devarajan
force-pushed
the
improve/read_all_opt
branch
from
199ceca
to
dbfcd36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading small 4KB chunks are very slow so replacing it by reading all data into user buffer directly.
Fixes part of #36