-
-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(share_plus): #3322 Image preview on iOS downscale to avoid issues #3320
fix(share_plus): #3322 Image preview on iOS downscale to avoid issues #3320
Conversation
Hello, thanks for the contribution. I'd please ask you to follow the PR template: https://github.com/fluttercommunity/plus_plugins/blob/main/.github/PULL_REQUEST_TEMPLATE.md and fix the title. As well, try to provide more context about this fix, ideally creating a bug report showcasing the issue, or showing before and after images, etc. otherwise it is very hard to understand what the purpose of the fix is. |
e827759
to
f0d8d96
Compare
Thanks for providing a ticket with a video recording! Can you show a recording of how it looks with the fix? |
114_1729250336.mp4 |
9e31a92
to
0c8fd51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
Description
On iPhone 13, when sharing an image and the image is very large, the sharing box may occasionally fail to be awakened.
Related Issues
Checklist
CHANGELOG.md
nor the plugin version inpubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).