Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logic from Polymer elements to plain JS files #320

Merged
merged 14 commits into from
Jan 9, 2017
Merged

Conversation

jonnor
Copy link
Member

@jonnor jonnor commented Jan 5, 2017

And start of de-Polymerization in the-graph-thumb, ref #314

@jonnor
Copy link
Member Author

jonnor commented Jan 6, 2017

Looks like our test is a bit racy, occationally fails on Saucelabs. Probably because the Polymer element is not always ready when the tests start running...

@jonnor jonnor changed the title Bundle as a plain-JS library Move logic from Polymer elements to plain JS files Jan 6, 2017
@jonnor
Copy link
Member Author

jonnor commented Jan 6, 2017

Before

  431 the-graph-editor/the-graph-editor.html
  222 the-graph-nav/the-graph-nav.html
  462 the-graph/the-graph.html
  293 the-graph-thumb/the-graph-thumb.html
 1408 total

now

  194 the-graph-editor/the-graph-editor.html
  171 the-graph-nav/the-graph-nav.html
  340 the-graph/the-graph.html
  112 the-graph-thumb/the-graph-thumb.html
  817 total

@jonnor jonnor mentioned this pull request Jan 6, 2017
21 tasks
@jonnor jonnor requested a review from bergie January 6, 2017 14:59
Copy link
Member

@bergie bergie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jonnor jonnor merged commit 32adab8 into master Jan 9, 2017
@jonnor jonnor deleted the librarify branch March 2, 2017 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants