Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseFloat numerical metadata #31

Merged
merged 3 commits into from
Apr 17, 2015
Merged

parseFloat numerical metadata #31

merged 3 commits into from
Apr 17, 2015

Conversation

forresto
Copy link
Contributor

@forresto
Copy link
Contributor Author

This one is ready. @bergie review?

bergie added a commit that referenced this pull request Apr 17, 2015
parseFloat numerical metadata
@bergie bergie merged commit 0d883f4 into master Apr 17, 2015
@davidmaxwaterman
Copy link

I only just looked at this, but it only seems to be addressing x/y metadata...what about other numeric data like width and height? I'd almost say to try to parse it as a number and if it fails then use a string. IIRC, the specific problem I was having was because it was x+width and y+height, so I guess it'll work if just one of them is numeric.

@bergie
Copy link
Member

bergie commented Apr 17, 2015

@davidmaxwaterman actually width and height shouldn't be specified at this level at all, see flowhub/the-graph#209

@bergie bergie deleted the forresto-xy branch April 17, 2015 13:40
@davidmaxwaterman
Copy link

hrm, ok, but that makes me wonder what happens when you import the file again...is everything the same as it was before?

@forresto
Copy link
Contributor Author

As it is now, width is always 72 and height is a function of the number of ports (something like Math.max(72, 8*n)).

@davidmaxwaterman
Copy link

ok, fair enough. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants