Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip EAP Jetbrains editions in Vuln processing #23400

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mostlikelee
Copy link
Contributor

#22723

  • added CPE translation (needs to be above existing jetbrains translation rules)

  • added using of of local translations file in nvdtools

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

  • Added/updated tests

  • Manual QA for all new/changed functionality

@iansltx
Copy link
Member

iansltx commented Oct 30, 2024

This feels a bit too broad? If I'm sitting on an older EAP that is vulnerable, there should be a way to have a CPE that matches that EAP, and Fleet should flag my EAP install.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (9e91549) to head (e4962ca).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23400      +/-   ##
==========================================
- Coverage   63.08%   53.45%   -9.63%     
==========================================
  Files        1555     1555              
  Lines      147024   147024              
  Branches     3696     3696              
==========================================
- Hits        92749    78598   -14151     
- Misses      46940    61978   +15038     
+ Partials     7335     6448     -887     
Flag Coverage Δ
backend 53.43% <ø> (-10.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mostlikelee mostlikelee marked this pull request as draft October 30, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants