Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mastodon link to server email templates #23309

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jc0b
Copy link

@jc0b jc0b commented Oct 28, 2024

  • Adds a link to FleetDM's Mastodon account to emails sent by the FleetDM server
  • Adds a Mastodon SVG image to the repo

@jc0b jc0b requested a review from a team as a code owner October 28, 2024 21:17
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.35%. Comparing base (6b62f3f) to head (92298ed).
Report is 64 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #23309    +/-   ##
========================================
  Coverage   63.35%   63.35%            
========================================
  Files        1538     1545     +7     
  Lines      144703   144846   +143     
  Branches     3601     3675    +74     
========================================
+ Hits        91670    91771   +101     
- Misses      45798    45839    +41     
- Partials     7235     7236     +1     
Flag Coverage Δ
frontend 52.42% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like other logos are .png and named <something>-logo-<dimensions>@2x.png — we should follow those conventions

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I just took the SVG from Mastodon's brand toolkit. Because these are vector graphics it didn't really feel appropriate to add a resolution (as it technically doesn't have one). I can convert it to PNG of the same size if that's more desirable.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked and there are a few other SVG graphics in that same directory. Let me know if you want the Mastodon one converted to a 48x48 PNG :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants