Fleet UI: Teams dropdown refactor (upgrade to react-select-5, accessible via keyboard) #23288
Conversation
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Error
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23288 +/- ##
==========================================
- Coverage 53.58% 53.58% -0.01%
==========================================
Files 1555 1555
Lines 146879 146914 +35
Branches 3711 3737 +26
==========================================
+ Hits 78701 78718 +17
- Misses 61725 61743 +18
Partials 6453 6453
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RachelElysia
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
| @@ -66,26 +86,179 @@ const TeamsDropdown = ({ | |||
| (option) => selectedTeamId === option.value | |||
| ) | |||
| ? selectedTeamId | |||
| : teamOptions[0]?.value; | |||
| : teamOptions[0]?.value || 0; // Fallback to 0 or another default value | |||
There was a problem hiding this comment.
Is this default going to interfere with correctly selecting "All teams"? From the surface it looks like this would select "No team" by default, and we don't necessarily want that behavior.
| stroke: COLORS["core-vibrant-blue-over"], | ||
| }, | ||
| }, | ||
| // TODO: Figure out a way to apply separate &:focus-visible styling |
There was a problem hiding this comment.
Does this TODO need to be resolved now? If not, can you mention it in an issue somewhere?
| placeholder="All teams" | ||
| onChange={(newValue) => { |
There was a problem hiding this comment.
Are the values here team objects rather than IDs, such that all teams/no team work correctly?
Issue
Originally #22606
Part 1 of #23266
Description
react-select-5which is version 5.4.0 instead of version 1.3.0Screenrecording
https://www.loom.com/share/aad6db3787054b3b9c7fdbb9f807e4e4?sid=b15317bb-cb21-4df5-92d0-9e3139ff90f3
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.