Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate list queries #23094

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Paginate list queries #23094

wants to merge 17 commits into from

Conversation

jacobshandling
Copy link
Contributor

@jacobshandling jacobshandling commented Oct 22, 2024

TODO

#21855

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added support on fleet's osquery simulator cmd/osquery-perf for new osquery data ingestion features.
  • Added/updated tests
  • If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes
  • If database migrations are included, checked table schema to confirm autoupdate
  • For database migrations:
    • Checked schema for all modified table for columns that will auto-update timestamps during migration.
    • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
    • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).
  • Manual QA for all new/changed functionality
  • For Orbit and Fleet Desktop changes:
    • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
    • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 44.68085% with 78 lines in your changes missing coverage. Please review.

Project coverage is 63.13%. Comparing base (b4a5a1f) to head (af4978d).

Files with missing lines Patch % Lines
server/service/queries.go 28.20% 26 Missing and 2 partials ⚠️
...es/queries/ManageQueriesPage/ManageQueriesPage.tsx 5.26% 18 Missing ⚠️
...eriesPage/components/QueriesTable/QueriesTable.tsx 67.56% 11 Missing and 1 partial ⚠️
server/datastore/mysql/queries.go 63.33% 7 Missing and 4 partials ⚠️
frontend/services/entities/queries.ts 0.00% 6 Missing ⚠️
frontend/hooks/usePlatformCompatibility.tsx 0.00% 1 Missing ⚠️
frontend/hooks/usePlatformSelector.tsx 0.00% 1 Missing ⚠️
frontend/utilities/sql_tools.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23094      +/-   ##
==========================================
- Coverage   63.14%   63.13%   -0.02%     
==========================================
  Files        1556     1556              
  Lines      147290   147316      +26     
  Branches     3669     3670       +1     
==========================================
- Hits        93013    93004       -9     
- Misses      46916    46948      +32     
- Partials     7361     7364       +3     
Flag Coverage Δ
backend 63.99% <45.83%> (-0.01%) ⬇️
frontend 52.22% <43.47%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* UI flash and lose search field focus when updating search or platform filter
* Query action buttons (manage, add query) hidden when no filtered queries but still non-filtered queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant