Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sandbox infrastructure directory #16902

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Remove sandbox infrastructure directory #16902

merged 2 commits into from
Feb 21, 2024

Conversation

lukeheath
Copy link
Member

These are unused and triggering several dozen code security warnings. Do y'all see any issue with removing these files?

@zwass
Copy link
Member

zwass commented Feb 15, 2024

Definitely most interested in Robert's thoughts, but seems to me if we ever need any of these things again we will grab them from the git history.

rfairburn
rfairburn previously approved these changes Feb 15, 2024
Copy link
Contributor

@rfairburn rfairburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with doing this from my end. We can always pull it back from an old revision of the repo if we need it again.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e3c0ef) 65.92% compared to head (af3d17a) 66.03%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16902      +/-   ##
==========================================
+ Coverage   65.92%   66.03%   +0.10%     
==========================================
  Files        1144     1144              
  Lines      101502   101537      +35     
  Branches     2530     2530              
==========================================
+ Hits        66914    67047     +133     
+ Misses      29604    29520      -84     
+ Partials     4984     4970      -14     
Flag Coverage Δ
backend 67.13% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukeheath lukeheath merged commit 186fdec into main Feb 21, 2024
21 checks passed
@lukeheath lukeheath deleted the remove-sandbox branch February 21, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants