Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: file_system_meta_data did not show all results for a file object across firmwares #1274

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

rhelmke
Copy link
Collaborator

@rhelmke rhelmke commented Sep 27, 2024

When an unpacked and analyzed file has the same name across firmware images, the file_system_meta_data plugin did not show the results for all firmware images in the file object view.

@rhelmke rhelmke self-assigned this Sep 27, 2024
Copy link
Collaborator

@jstucke jstucke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but it seems test_file_system_metadata_routes.py needs a fix

@rhelmke
Copy link
Collaborator Author

rhelmke commented Sep 30, 2024

Should be fixed now

Copy link
Collaborator

@jstucke jstucke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jstucke jstucke merged commit d96db1d into master Sep 30, 2024
10 checks passed
@jstucke jstucke deleted the bugfix-file-system-meta-data-ajax-route-result branch September 30, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants