Skip to content

Commit

Permalink
perf: fast path if no blob files are dropped
Browse files Browse the repository at this point in the history
  • Loading branch information
marvin-j97 committed Aug 22, 2024
1 parent 92a0423 commit aa3b020
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions src/value_log.rs
Original file line number Diff line number Diff line change
Expand Up @@ -309,18 +309,22 @@ impl<C: Compressor + Clone> ValueLog<C> {
.cloned()
.collect::<Vec<_>>();

let disk_space: u64 = segments.iter().map(|x| x.meta.compressed_bytes).sum();
let bytes_freed = segments.iter().map(|x| x.meta.compressed_bytes).sum();

let ids = segments.iter().map(|x| x.id).collect::<Vec<_>>();

log::info!("Dropping stale blob files: {ids:?}");
self.manifest.drop_segments(&ids)?;
if ids.is_empty() {
log::trace!("No blob files to drop");
} else {
log::info!("Dropping stale blob files: {ids:?}");
self.manifest.drop_segments(&ids)?;

for segment in segments {
std::fs::remove_file(&segment.path)?;
for segment in segments {
std::fs::remove_file(&segment.path)?;
}
}

Ok(disk_space)
Ok(bytes_freed)
}

/// Marks some segments as stale.
Expand Down

0 comments on commit aa3b020

Please sign in to comment.