Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make storage emulator content type parser case insensitive #4824

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

Yuangwang
Copy link
Contributor

Description

Make storage emulator content type parser case insensitive, fixes part of #3953

Scenarios Tested

Manual testing with the setup described in #3953 and also added unit test for this specific case

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #4824 (018ddfb) into master (11bc020) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4824   +/-   ##
=======================================
  Coverage   57.73%   57.73%           
=======================================
  Files         287      287           
  Lines       18734    18734           
  Branches     3699     3699           
=======================================
  Hits        10816    10816           
  Misses       7032     7032           
  Partials      886      886           
Impacted Files Coverage Δ
src/emulator/storage/multipart.ts 95.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@tonyjhuang tonyjhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants