Align storage emulator with GCS #4008
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getting the metadata first to determie uploaded file name
|
Hi @kenttregenza, as mentioned on #3953, could you please rebase off master and split this into two separate PRs, one of the name change and one for the multipart-related changes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Align storage emulator with GCS way of handling name. Simply this gets the name from either the query parameter or the metadata. In the process this patch tries to improve the multipart handling as the Python client puts quotes around the boundary value in the content type header. Fixes #3953
Scenarios Tested
Using Google Cloud Storage client for Python. Uploading a small file (that uses multipart) and a large file that simulates a resume able upload
Sample Commands
NA