Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialect on create_database and no_db_trigger support #152

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Dialect on create_database and no_db_trigger support #152

merged 3 commits into from
Jan 10, 2024

Conversation

fernandobatels
Copy link
Owner

The dialect connection builder options now are also applied on database creation, provided by create_database method.

no_db_trigger option added on connection builder, applied on database connection, disabling the database triggers. Table triggers are no affected.

@fernandobatels
Dialect fixed
755275d 
Utilization of dialect options on database creation and attachament
fixed. Basically, the dialect param was only in use on stmt commands.

Issue #150
@fernandobatels
No db triggers support
2ad8733 
Added an option 'no_db_trigger' on connection builder for disabled
the database triggers, like the ones when the client connect.

Issue #151
@fernandobatels fernandobatels self-assigned this Jan 5, 2024
@fernandobatels
Dialect default
434cc06 
Enum dialect fixed to use the D3 as default
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 7472468209

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 84.123%
Totals Coverage Status
Change from base Build 6736963609: 0.3%
Covered Lines: 2681
Relevant Lines: 3187
💛 - Coveralls

@fernandobatels fernandobatels merged commit 3a5710c into master Jan 10, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jairinhohw jairinhohw Awaiting requested review from jairinhohw

Assignees

@fernandobatels fernandobatels

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fernandobatels @jairinhohw