fix(inline.ts): use xlink:href additionally to href in img #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
This pull request aim to resolve an issue about the
inlineResourcesfunction.When we try to use the
inlineResourcesfunction, an error is throw. The error is due to an empty URL given to thefetchResourcefunction. The URL is empty because theinlineResourcesfunction try to find the href of an image, but it appears that the href of the image element is changed before to an xlink:href attribute.With this simple workaround I propose, we should be able to retrieve URL from the href or xlink:href attribute.
Edit: this should resolve #170
Regards,
Valentin