-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Implement dataset module and add new documentation #101
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
- Coverage 94.85% 93.91% -0.95%
==========================================
Files 26 30 +4
Lines 1186 1249 +63
==========================================
+ Hits 1125 1173 +48
- Misses 61 76 +15 ☔ View full report in Codecov by Sentry. |
Related issue #102 |
@felipeffm as we've talked today, I think it would be nice to have a structure similar to sktime, with one function for each dataset |
might this also be relevant? |
yes! Felipe told me he won't be able to finish this PR due to bandwidth limitation, I'm planning to implement it inheriting |
Yes, that's right - it is just a design study at the moment, not even a fully developed API. It was created for the benefit of some contributors who were considering to work on this but then abandoned the project. So, if you create an API in |
Alright, I'll implement it in sktime and then use it in Prophetverse. I'm currently on vacation and should start working on that in about 2 weeks. |
Discuss:
how make documentation more readable for all:
Sugestion: separe advanced concepts and make it visual
how to simplify the code at examples.
Sugestion: preprocess outside code