Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat](gui) paint some buttons instead of using charactor symbol #712

Merged
merged 17 commits into from
Jul 12, 2023

Conversation

cosven
Copy link
Member

@cosven cosven commented Jun 16, 2023

  • Hide the sidebar and playerbar(bottom panel)
  • add blur effect for the floating box
    • After a few tries, I found it's hard to implement a good blur effect (it's hard to blur the background text). The QGraphicsBlurEffect can only blur the widget itself. The good news is that we can draw a blured pixmap.
  • add a Home button on the top
  • show the user avatar or the provider icon on the top 🤔
  • review the code
    • refine the process of showing pixmap
  • floating box background color

试用体验

  1. 播放/暂停歌曲操作有点麻烦(鼠标需要先 hover 到图片,然后移动到按钮上)
  2. 浮动窗口上的歌曲名太短(歌曲名最好能在界面上一直显示,而不是需要将鼠标 hover 上去才显示)

image

@cosven cosven changed the title WIP: gui: (may be) a branch new GUI WIP: [feat](gui) (may be) a branch new GUI Jun 16, 2023
@cosven cosven changed the title WIP: [feat](gui) (may be) a branch new GUI WIP: [feat](gui) (may be) a brand new GUI Jun 16, 2023
rotate cover

seems ok

almost ok
@cosven cosven changed the title WIP: [feat](gui) (may be) a brand new GUI [feat](gui) paint button instead of using charactor symbol Jul 12, 2023
@cosven cosven changed the title [feat](gui) paint button instead of using charactor symbol [feat](gui) paint some buttons instead of using charactor symbol Jul 12, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5533481590

  • 376 of 985 (38.17%) changed or added relevant lines in 26 files are covered.
  • 38 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-1.9%) to 59.764%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/gui/uimain/toolbar.py 16 17 94.12%
feeluown/gui/uimodels/provider.py 1 2 50.0%
feeluown/gui/uimain/player_bar.py 19 21 90.48%
feeluown/gui/widgets/cover_label.py 4 6 66.67%
feeluown/gui/helpers.py 3 6 50.0%
feeluown/gui/uimain/sidebar.py 18 21 85.71%
feeluown/gui/ui.py 1 6 16.67%
feeluown/gui/components/volume_slider.py 6 14 42.86%
feeluown/gui/pages/recently_played.py 6 16 37.5%
feeluown/gui/widgets/settings.py 5 16 31.25%
Files with Coverage Reduction New Missed Lines %
feeluown/gui/uimain/toolbar.py 1 76.39%
feeluown/gui/widgets/settings.py 1 27.54%
feeluown/gui/uimain/player_bar.py 7 91.72%
feeluown/gui/widgets/playlist_button.py 11 0%
feeluown/gui/widgets/provider.py 18 21.24%
Totals Coverage Status
Change from base Build 5209719285: -1.9%
Covered Lines: 8514
Relevant Lines: 14246

💛 - Coveralls

@cosven cosven merged commit cc824cf into feeluown:master Jul 12, 2023
8 of 9 checks passed
@cosven cosven deleted the ui-v390 branch July 12, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants