Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new footer at Mote's message #698

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Madhupatel08
Copy link

Added a new footer at Mote's message like:- https://getfedora.org/

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please undo the changes made on the README.md file?

It is irrelevant to the purpose of the pull request.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@gridhead gridhead linked an issue Mar 13, 2024 that may be closed by this pull request
@RuthM-K
Copy link

RuthM-K commented Mar 13, 2024

Thank you
@Madhupatel08 any way I can help with the blocked merge?Maybe I can help with solving the issue? I'm an Outreachy applicant

@gridhead
Copy link
Member

@RuthM-K please go ahead and make the pushes to this branch.

Copy link
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The positioning is done incorrectly and the reference to the image is broken in this preview.

image

Please make the suggested changes and squash the commits to just one.

@@ -48,4 +48,17 @@
</span>
</div>
</div>
<div class="mx-auto flex max-w-screen-xl flex-wrap lg:flex-nowrap lg:justify-center">
<div class="w-[200px] flex-none pb-6 lg:pb-0">
<img class="FPImage mb-2 xl:mb-0" src="../imgs/red-hat-logo.png" alt="Sponsored by Red Hat Logo">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refrain from using relative references in the assets and use Static Files to refer to these files.

</div>
<div class="w-full">
<div class="flex justify-center px-4">
<p class="text-white">Fedora is sponsored by Red Hat. <a href="https://docs.fedoraproject.org/en-US/quick-docs/fedora-and-red-hat-enterprise-linux/" class="block w-full text-fp-gray underline underline-offset-1"><!--[-->Learn more about the relationship between Red Hat and Fedora.<!--]--></a></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the square brackets are commented out over there?

Is it possible to remove them because they are not visible anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add relevant links in the footer
3 participants