-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue-170-added footer -siddhantkhariwal #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have kept both the sites, side-by-side for comparison.
Some changes, I'd suggest
- Remove the margin from the top side now that we have the footer?
- Align the links and link headers to the left side
- Ensure that the underline beneath the links are visible only when they are hovered upon
- Bring the three stacks a bit more close to each other
- Remove the unfinished implementation of Facebook and Twitter logos for now
- Remove the text that says
Fragment © 2021 Akashdeep Dhar and others
at the bottom - Reduce the font size to make it fall in line with the one of the description
- Ensure that the rows stack atop each other when the width decreases beyond a certain limit
Hey, @t0xic0der I have made the changes, please check it and let me know if any other changes are remaining. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attaching the updated screenshot here for reference
- The top side margin is still there. Please remove it.
- The group of links on the bottom looks a bit inclined towards the left side. Note that I'm not talking about the alignment of one link but the group as a whole - which should be in the center.
- The font sizes have stayed the same. Please make it small enough to fall in line with the one of the description.
- I tried progressively reducing the width and the rows do not stack atop each other. Please ensure that happens.
Hey @t0xic0der , I have done the changes except for the responsive stack one. I am having trouble doing that. |
@t0xic0der have you checked this? |
Closing this as stale |
DESCRIPTION
Added footer with all the footer links and RedHat logo.
social media logos are showing a blank square.
issue- #170