issue-170-added footer -siddhantkhariwal #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gridhead
requested changes
Oct 4, 2021
There was a problem hiding this comment.
I have kept both the sites, side-by-side for comparison.
Some changes, I'd suggest
- Remove the margin from the top side now that we have the footer?
- Align the links and link headers to the left side
- Ensure that the underline beneath the links are visible only when they are hovered upon
- Bring the three stacks a bit more close to each other
- Remove the unfinished implementation of Facebook and Twitter logos for now
- Remove the text that says
Fragment © 2021 Akashdeep Dhar and othersat the bottom - Reduce the font size to make it fall in line with the one of the description
- Ensure that the rows stack atop each other when the width decreases beyond a certain limit
|
Hey, @t0xic0der I have made the changes, please check it and let me know if any other changes are remaining. |
gridhead
requested changes
Oct 7, 2021
There was a problem hiding this comment.
Attaching the updated screenshot here for reference
- The top side margin is still there. Please remove it.
- The group of links on the bottom looks a bit inclined towards the left side. Note that I'm not talking about the alignment of one link but the group as a whole - which should be in the center.
- The font sizes have stayed the same. Please make it small enough to fall in line with the one of the description.
- I tried progressively reducing the width and the rows do not stack atop each other. Please ensure that happens.
Hey @t0xic0der , I have done the changes except for the responsive stack one. I am having trouble doing that. |
|
@t0xic0der have you checked this? |
|
Closing this as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Added footer with all the footer links and RedHat logo.
social media logos are showing a blank square.
issue- #170