Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Close #13 save bad rows to a file #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dimus
Copy link

@dimus dimus commented Mar 3, 2020

This PR is about #13 feature request.
It is my first Rust exercise, would be great to learn how does it go.

@emk
Copy link
Contributor

emk commented Mar 30, 2020

Thank you for a great patch, and my apologies for a slow response! I'm going to revisit scrubcsv sometime in the next couple of weeks, and when I do, I'm going to tweak your patch slightly and include it.

Your Rust code looks great!

@ngirard
Copy link

ngirard commented Mar 21, 2021

This would be nice to have ;-)

@jtara1
Copy link

jtara1 commented Feb 11, 2022

I'm getting an error when it attempts to write malformed rows to the file.

$ scrubcsv -d $'\t' --bad-rows-path temp.tsv input.tsv > /dev/null
ERROR: cannot write record
  caused by: CSV error: found record with 102 fields, but the previous record has 107 fields

Would it make more sense to append malformed rows to a file than to use a csv writer to append which validates it's csv?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants