No block slurm #2965
Draft
No block slurm #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
I am currently testing this on our workstation and cluster. |
vilhub
reviewed
Oct 18, 2024
plugins/hydra_submitit_launcher/hydra_plugins/hydra_submitit_launcher/submitit_launcher.py
Outdated
Show resolved
Hide resolved
…auncher/submitit_launcher.py Co-authored-by: vilhub <vilavil@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I am using hydra for ML and I need to run my training on the HPC. Our HPC does not allow long running jobs on the login node, so to utilise the hydra submitit launcher it needs to be non-blocking.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I have run the unit tests for plugin and also added an additional one specifically for the changes made.
I have not extensively tested this change with the sweeper, as I am not expecting to use the sweeper with it, however, I have added sentinel values for the job returns to prevent the sweeper from raising an error. It should be noted in the documentation that this feature is not designed to function with the sweeper. I do not think it needs to be, since sweeping generally does not take long running jobs, and should be performed on smaller datasets and training sessions which last less than a few hours.
Related Issues and PRs
This potentially fixes #2479.