Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend list function #2950

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Extend list function #2950

merged 3 commits into from
Oct 15, 2024

Conversation

jesszzzz
Copy link
Contributor

Motivation

#1547
There is currently no clean way to append to a list using the override syntax. It was suggested in the above issue that this could be done by adding a custom function, so that's what this PR does. It means that if the config is:

extras:
    tags: [experiment, trial_1]

composing the config with this as an override:
extras.tags="extend_list(another_tag, yet_another_tag)"

would generate

extras:
    tags: [experiment, trial_1, another_tag, yet_another_tag]

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Added unit tests that pass, also checked the added documentation looks correct using yarn start

Related Issues and PRs

#1547

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2024
@omry omry requested a review from Jasha10 September 12, 2024 04:40
@jesszzzz jesszzzz merged commit 4d9d6e7 into main Oct 15, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants