Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to omegaconf custom resolvers to fix 2839 #2881

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

gerard-sanroma
Copy link
Contributor

Motivation

Aside from the resolvers provided by hydra, there is the possibility to include custom resolvers, which adds a lot of flexibility to hydra.
This is motivated by Issue 2839 which asks whether is possible to include the SHA of the git revision in the name of the ouput dir, a good practice to link the experiment artifacts with the commit that produced them. This can be trivially done by adding a custom omegaconf resolver.

The possibility of using custom resolvers was not documented.
This PR adds a link in the doc pointing to the possibility of using custom resolvers.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

N/A

Related Issues and PRs

Related to issue 2839

@facebook-github-bot
Copy link
Contributor

Hi @gerard-sanroma!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link
Collaborator

@Jasha10 Jasha10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gerard-sanroma.

@Jasha10 Jasha10 merged commit 2e682d8 into facebookresearch:main Apr 3, 2024
11 of 24 checks passed
@gerard-sanroma gerard-sanroma deleted the fix/2839 branch April 4, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants