missing 'and' in docs #2808
Merged
missing 'and' in docs #2808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
It looks to me like the CI failures are unrelated, so I'm not digging too hard for now, but let me know if I've mis-diagnosed! |
|
Yeah, CI needs some love. Thanks for the typo fix! |
odelalleau
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I was reading https://hydra.cc/docs/1.1/advanced/compose_api/#initialization-methods and there seemed to be a missing "and" in the flow of the text.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Docs-only change, only 'testing' needing is a maintainer to check that this is what was intended.
Related Issues and PRs
I didn't both opening an issue for this as it felt like creating more noise for the maintainers, but if it aids your workflow, I'm happy to create an issue, just let me know.