Add support for zzzz (and beyond) in format_datetime #11330
+473
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D64795407 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 24, 2024
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
|
This pull request was exported from Phabricator. Differential Revision: D64795407 |
kevinwilfong
force-pushed
the
export-D64795407
branch
from
cf2ef03
to
c529fed
Compare
kevinwilfong
requested review from
assignUser and
majetideepak
as code owners
…or#11283) Summary: Pull Request resolved: facebookincubator#11283 The format_datetime currently outptus the time zone id if for 3 or fewer 'z' characters in the format string. However, the JODA library, which this is based on, does this for 3 or more 'Z' characters. https://www.joda.org/joda-time/apidocs/org/joda/time/format/DateTimeFormat.html This diff fixes this, as well as adds support for a single 'Z' (which outputs the same thing as 'ZZ' just without the colon). So 'Z' is fully supported for any number of characters. Differential Revision: D64500193
|
This pull request was exported from Phabricator. Differential Revision: D64795407 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 24, 2024
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
kevinwilfong
force-pushed
the
export-D64795407
branch
from
c529fed
to
eef1592
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64795407 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 24, 2024
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
kevinwilfong
force-pushed
the
export-D64795407
branch
from
eef1592
to
7420735
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64795407 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 24, 2024
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
kevinwilfong
force-pushed
the
export-D64795407
branch
from
7420735
to
81b1219
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64795407 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 24, 2024
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
kevinwilfong
force-pushed
the
export-D64795407
branch
from
81b1219
to
4e23457
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64795407 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 25, 2024
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
kevinwilfong
force-pushed
the
export-D64795407
branch
from
4e23457
to
aa187ff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64795407 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 25, 2024
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
kevinwilfong
force-pushed
the
export-D64795407
branch
from
aa187ff
to
b8dfe40
Compare
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 26, 2024
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
kevinwilfong
force-pushed
the
export-D64795407
branch
from
b8dfe40
to
2a2ced5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64795407 |
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
|
This pull request was exported from Phabricator. Differential Revision: D64795407 |
kevinwilfong
force-pushed
the
export-D64795407
branch
from
2a2ced5
to
746eaa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's
forma_datetime function.
This is used to format long time zone names.
Long time zone names are not available from the IANA time zone database, so we
can't use the tz library to generate these. Fortunately, unicode provides some
utilities to generate these.
Differential Revision: D64795407