-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for zzzz (and beyond) in format_datetime #11330
base: main
Are you sure you want to change the base?
Add support for zzzz (and beyond) in format_datetime #11330
Conversation
✅ Deploy Preview for meta-velox canceled.
|
This pull request was exported from Phabricator. Differential Revision: D64795407 |
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
This pull request was exported from Phabricator. Differential Revision: D64795407 |
cf2ef03
to
c529fed
Compare
…or#11283) Summary: Pull Request resolved: facebookincubator#11283 The format_datetime currently outptus the time zone id if for 3 or fewer 'z' characters in the format string. However, the JODA library, which this is based on, does this for 3 or more 'Z' characters. https://www.joda.org/joda-time/apidocs/org/joda/time/format/DateTimeFormat.html This diff fixes this, as well as adds support for a single 'Z' (which outputs the same thing as 'ZZ' just without the colon). So 'Z' is fully supported for any number of characters. Differential Revision: D64500193
This pull request was exported from Phabricator. Differential Revision: D64795407 |
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
c529fed
to
eef1592
Compare
This pull request was exported from Phabricator. Differential Revision: D64795407 |
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
eef1592
to
7420735
Compare
This pull request was exported from Phabricator. Differential Revision: D64795407 |
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
7420735
to
81b1219
Compare
This pull request was exported from Phabricator. Differential Revision: D64795407 |
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
81b1219
to
4e23457
Compare
This pull request was exported from Phabricator. Differential Revision: D64795407 |
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
4e23457
to
aa187ff
Compare
This pull request was exported from Phabricator. Differential Revision: D64795407 |
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
aa187ff
to
b8dfe40
Compare
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
b8dfe40
to
2a2ced5
Compare
This pull request was exported from Phabricator. Differential Revision: D64795407 |
…or#11330) Summary: Pull Request resolved: facebookincubator#11330 This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's forma_datetime function. This is used to format long time zone names. Long time zone names are not available from the IANA time zone database, so we can't use the tz library to generate these. Fortunately, unicode provides some utilities to generate these. Differential Revision: D64795407
This pull request was exported from Phabricator. Differential Revision: D64795407 |
2a2ced5
to
746eaa6
Compare
Summary:
This diff adds support for JODA's zzzz (or more) patterns (all equivalent) in Presto's
forma_datetime function.
This is used to format long time zone names.
Long time zone names are not available from the IANA time zone database, so we
can't use the tz library to generate these. Fortunately, unicode provides some
utilities to generate these.
Differential Revision: D64795407