Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate SRStatusNoStatusReceived and update naming for consistency #695

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

Deprecate SRStatusNoStatusReceived and update naming for consistency #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6801a3d
Renamed SRStatusNoStatusReceived to SRStatusCodeNoStatusReceived for …
nnabeyang Oct 16, 2024
849d54c
Replace SRStatusNoStatusReceived with the deprecated SRStatusCodeNoSt…
nnabeyang Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion SocketRocket/SRWebSocket.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ typedef NS_ENUM(NSInteger, SRStatusCode) {
SRStatusCodeProtocolError = 1002,
SRStatusCodeUnhandledType = 1003,
// 1004 reserved.
SRStatusNoStatusReceived = 1005,
SRStatusCodeNoStatusReceived = 1005,
SRStatusNoStatusReceived __deprecated_enum_msg("Use SRStatusCodeNoStatusReceived") = SRStatusCodeNoStatusReceived,
SRStatusCodeAbnormal = 1006,
SRStatusCodeInvalidUTF8 = 1007,
SRStatusCodePolicyViolated = 1008,
Expand Down
2 changes: 1 addition & 1 deletion SocketRocket/SRWebSocket.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,7 @@ - (void)handleCloseWithData:(NSData *)data
}
}
} else {
_closeCode = SRStatusNoStatusReceived;
_closeCode = SRStatusCodeNoStatusReceived;
}

[self assertOnWorkQueue];
Expand Down