Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Consistent cache names #31239

Merged
merged 1 commit into from
Oct 14, 2024
Merged

[ci] Consistent cache names #31239

merged 1 commit into from
Oct 14, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Oct 14, 2024

Makes cache names more descriptive and consistent for CI, so it's easier to tell which cache is used for what purpose.

Stack created with Sapling. Best reviewed with ReviewStack.

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 3:53pm

@react-sizebot
Copy link

react-sizebot commented Oct 14, 2024

Comparing: b60286b...1f40228

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 507.80 kB 507.80 kB = 90.79 kB 90.79 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 512.74 kB 512.74 kB = 91.51 kB 91.51 kB
facebook-www/ReactDOM-prod.classic.js = 603.22 kB 603.22 kB = 106.69 kB 106.69 kB
facebook-www/ReactDOM-prod.modern.js = 579.41 kB 579.41 kB = 102.79 kB 102.79 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against acc549e

Makes cache names more descriptive and consistent for CI, so it's easier to tell which cache is used for what purpose.
@poteto poteto merged commit cbcc1d2 into main Oct 14, 2024
387 checks passed
@poteto poteto deleted the pr31239 branch October 14, 2024 16:07
poteto added a commit that referenced this pull request Oct 14, 2024
There was a concurrency setting we hadn't enabled on jobs that are
primarily triggered for PRs. This meant that every update to the PR
would trigger new CI jobs without canceling any ones already in flight,
which can greatly slow down CI due to the number of jobs that need to
run.

This PR adds concurrency [based on the workflow name and PR number or
head
ref.](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs)
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31240).
* __->__ #31240
* #31239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants