Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update full_result.json #858

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update full_result.json #858

wants to merge 4 commits into from

Commits on May 16, 2024

  1. Fix lint errors in github CI 

    Summary:
Unfortunately we still don't get flake8 errors on unused imports internally,
so I introduced a few of these when I was fixing broken unit tests in github
CI.

This should make the lint signal clean, so that on github only the `pyre`
and `pysa` signals will be red (they have been broken for a while, I'll try
to fix them but that will be in separate diffs).

Reviewed By: alexkassil

Differential Revision: D57386423
    @stroxler @facebook-github-bot
    stroxler authored and facebook-github-bot committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e6ea4fd View commit details
    Browse the repository at this point in the history

  2. Handle package changes in github CI 

    Summary:
The dataclasses-json version we are getting in github has types that
are incompatible with the internal version. As a result, we need to pin
the version on github to get comparable results (in addition it's at
least possible we would get bugs in open-source without pinning). I
filed T189226004 to bump the version internally.

In addition:
- we aren't marking `toml` as a dependency, but we need it as a dev
  dependency because type checking the typeshed patcher requires it
- we need to list both tabulate and toml in our .pyre_configuration
  for github to pick them up because we are still using the legacy
	setup where packages aren't picked up by default... this would
	probably be good to change at some point.

Reviewed By: arthaud

Differential Revision: D57387918
    @stroxler @facebook-github-bot
    stroxler authored and facebook-github-bot committed May 16, 2024
    Configuration menu
    Copy the full SHA
    58b264e View commit details
    Browse the repository at this point in the history

  3. Remove dead pyre-ignore directives (#855) 

    Summary:

The dataclasses-json version we are getting in github has types that
are incompatible with the internal version. As a result, we need to pin
the version on github to get comparable results (in addition it's at
least possible we would get bugs in open-source without pinning). I
filed T189226004 to bump the version internally.

In addition:
- we aren't marking `toml` as a dependency, but we need it as a dev
  dependency because type checking the typeshed patcher requires it
- we need to list both tabulate and toml in our .pyre_configuration
  for github to pick them up because we are still using the legacy
	setup where packages aren't picked up by default... this would
	probably be good to change at some point.

Differential Revision: D57433947
    @stroxler @facebook-github-bot
    stroxler authored and facebook-github-bot committed May 16, 2024
    Configuration menu
    Copy the full SHA
    11d1246 View commit details
    Browse the repository at this point in the history

  4. Update full_result.json 

    Summary:
This updates to what we are currently seeing in the integration tests.

There is a regression here: we don't seem to be resolving
werkzeug.utils.redirect properly; Maxime was able to verify that
reveal_type(redirect) comes back as `unknown`.

It's likely that this is either Pyre not finding the package due to some
configuration handling change, or a signature extraction issue.

I filed T189346515 to investigate, but it seems wise to make CI pass
in the meantime so that we'll notice the next regression quicker.

Differential Revision: D57437213
    @stroxler @facebook-github-bot
    stroxler authored and facebook-github-bot committed May 16, 2024
    Configuration menu
    Copy the full SHA
    8a1c3c1 View commit details
    Browse the repository at this point in the history