Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site package find #777

Closed

Conversation

WangGithubUser
Copy link
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

This PR fixed #773, and I think I descibed clearly in #773.

Test Plan

I can't build Pyre since I'm using Windows, but I test some pieces of code, and they looks work.

client/configuration/search_path.py Fixed Show fixed Hide fixed
client/configuration/search_path.py Fixed Show fixed Hide fixed
client/configuration/search_path.py Fixed Show fixed Hide fixed
client/configuration/search_path.py Fixed Show fixed Hide fixed
Well, I actually don't see why the status check will fail,
but the status check's suggestion seems not wrong...
Maybe there is an hidden issue?
@WangGithubUser
Copy link
Contributor Author

WangGithubUser commented Aug 20, 2023

I found a better way to fix it(in #773 (comment)), and I'll make another PR to fix this.

@WangGithubUser WangGithubUser deleted the fix_site_package_find branch August 20, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyre couldn't find a required site-package
2 participants