Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies require and level-set #766

Conversation

WangGithubUser
Copy link
Contributor

@WangGithubUser WangGithubUser commented Jul 28, 2023

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

This PR fixed #765 .
#765 caused by 2 reasons.

  1. We missed to install some dependencies.This is easy to find and fix, just as commit Complete the dependencies required for pyre.
  2. The second reason is a hidden issue.If you installed typing_extensions and typing_inspect, and have a look for the site-packages directory, you could see like this:
    image
    Obviously, they are top_level_modules.
    But, we didn't declare them as top_level_modules explicitly, so Pyre think it isn't exist.

Test Plan

Before this PR, step Run Pyre actually failed with error message Invalid configuration: Invalid path async_generator: does not exist.

After this PR, step Run Pyre was sucessfull.

And you can see, this PR's CI were all successful.

@WangGithubUser WangGithubUser changed the title Fix dependencies require and find Fix dependencies require and level-set Jul 28, 2023
@connernilsen
Copy link
Contributor

Hello @WangGithubUser, thanks for creating this fix. Is there a reason you removed typing_inspect from the dependency list when you added async_generator?

@WangGithubUser
Copy link
Contributor Author

@connernilsen I deleted the require of async_generator just now.I remove the require of typing_extensions but use typing_inspect because typing_inspect already required typing_extensions.

@facebook-github-bot
Copy link
Contributor

@connernilsen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@connernilsen merged this pull request in 91e7256.

@WangGithubUser WangGithubUser deleted the Fix_dependencies_require_and_find branch August 3, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyre fail with a dependencies not found error
3 participants