Fix dependencies require and level-set #766
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit install
pre-commit run
Summary
This PR fixed #765 .
#765 caused by 2 reasons.
Complete the dependencies required for pyre
.typing_extensions
andtyping_inspect
, and have a look for thesite-packages
directory, you could see like this:Obviously, they are
top_level_modules
.But, we didn't declare them as
top_level_modules
explicitly, so Pyre think it isn't exist.Test Plan
Before this PR, step
Run Pyre
actually failed with error messageInvalid configuration: Invalid path async_generator: does not exist.
After this PR, step
Run Pyre
was sucessfull.And you can see, this PR's CI were all successful.