Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CI dependencies #764

Closed

Conversation

WangGithubUser
Copy link
Contributor

@WangGithubUser WangGithubUser commented Jul 28, 2023

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

Most of our CI dependencies were outdated, so I upgraded them(As commit Upgrade CI dependencies)
And, I set the python-version in setup-python explicitly for the v4 of setup-python need.

Test Plan

All of the warnings and errors about Action configuration were fixed.

Most of CI dependencies are outdated, so I did these upgrade for all actions:

actions/checkout@v2 => actions/checkout@v3
actions/setup-python@v2 => actions/setup-python@v4
JamesIves/github-pages-deploy-action@releases/v3 => JamesIves/github-pages-deploy-action@releases/v4
actions/upload-artifact@v2 => actions/upload-artifact@v3
github/codeql-action/upload-sarif@v1 => github/codeql-action/upload-sarif@v2
We need to provide the python-version explicitly when setup python
to avoid the warning during setup.
@connernilsen
Copy link
Contributor

Hey @WangGithubUser, thanks for creating this PR. I'll bring this up in our next team meeting and let you know what we think.

@facebook-github-bot
Copy link
Contributor

@connernilsen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@connernilsen merged this pull request in 3884a88.

@WangGithubUser WangGithubUser deleted the upgrade_CI_dependencies branch August 3, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants