Display positions in SinkDuplicate errors

[abishekvashok]

Pre-submission checklist

• I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
• pre-commit run

Summary

Previously when SinkDuplicate errors occured, we just displayed a note. Now we can display locations where the duplicates occured.

Modifies and updates test as well.

Test Plan

• Post changes with the default taint.config, running pysa on documentation/pysa_tutorial/exercise1

• Modify taint.config to:

{
  "sources": [
    {
      "name": "CustomUserControlled",
      "comment": "use to annotate user input"
    }
  ],

  "sinks": [
    {
      "name": "CodeExecution",
      "comment": "use to annotate execution of python code"
    },
    {
      "name": "CodeExecution",
      "comment": "duplicate for testing"
    }
  ],

  "features": [],

  "rules": [
    {
      "name": "Possible RCE:",
      "code": 5001,
      "sources": [ "CustomUserControlled" ],
      "sinks": [ "CodeExecution" ],
      "message_format": "User specified data may reach a code execution sink"
    }
  ]
}

Before this PR:

After this PR:

• make test

Fixes part of: MLH-Fellowship#82
Signed-off-by: Abishek V Ashok abishekvashok@gmail.com

[facebook-github-bot]

@r0rshark has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@r0rshark merged this pull request in 57de96e.