Skip to content

Commit

Permalink
Move the EdgesValue module down to the shared-memory block
Browse files Browse the repository at this point in the history
Summary:
Moving this before dong the compute vs storage split makes the
diffs and resulting code clearer.

justmovingthingsaround

Reviewed By: kinto0

Differential Revision: D52182021

fbshipit-source-id: b84287307e69a37e129cc3fe42d508522414ab8d
  • Loading branch information
stroxler authored and facebook-github-bot committed Dec 15, 2023
1 parent a501866 commit d9a02d4
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions source/analysis/classHierarchyEnvironment.ml
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,6 @@ let empty_stub_environment alias_environment =
AliasEnvironment.ReadOnly.empty_stub_environment alias_environment


module EdgesValue = struct
type t = ClassHierarchy.Edges.t option

let prefix = Hack_parallel.Std.Prefix.make ()

let description = "Edges"

let equal = Memory.equal_from_compare [%compare: ClassHierarchy.Edges.t option]
end

let compute_extends_placeholder_stub_class
{ Node.value = { ClassSummary.bases = { base_classes; metaclass; _ }; _ }; _ }
~aliases
Expand Down Expand Up @@ -230,6 +220,16 @@ let get_parents alias_environment name ~dependency =
Some { ClassHierarchy.Edges.parents; generic_base; has_placeholder_stub_parent }


module EdgesValue = struct
type t = ClassHierarchy.Edges.t option

let prefix = Hack_parallel.Std.Prefix.make ()

let description = "Edges"

let equal = Memory.equal_from_compare [%compare: ClassHierarchy.Edges.t option]
end

module Edges = Environment.EnvironmentTable.WithCache (struct
module PreviousEnvironment = PreviousEnvironment
module Key = SharedMemoryKeys.StringKey
Expand Down

0 comments on commit d9a02d4

Please sign in to comment.