Skip to content

Commit

Permalink
Improve logging detail of connectivity issues
Browse files Browse the repository at this point in the history
Summary:
Here we capture and persist the full stack trace of any connectivity problems in communicating with the pyre server daemon instance from the pyre client.

This will aid us in further investigating the root cause of any connectivity/stability issues which pyre codenav has been impacted by

Reviewed By: inseokhwang

Differential Revision: D50736810

fbshipit-source-id: 46a950cd60e8c5b56ead95a37549738fcc3fb3de
  • Loading branch information
jasontatton authored and facebook-github-bot committed Oct 27, 2023
1 parent a57a955 commit 7f19591
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion client/language_server/daemon_connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import contextlib
import dataclasses
import logging
import traceback
from pathlib import Path
from typing import AsyncIterator, Union

Expand Down Expand Up @@ -101,5 +102,5 @@ async def attempt_send_async_raw_request(
) as error:
return DaemonConnectionFailure(
"Could not establish connection with an existing Pyre server "
f"at {socket_path}: {error}"
f"at {socket_path}: {error}. Type: {type(error)}. Stacktrace: {traceback.format_exc( limit = None, chain = True)}"
)

0 comments on commit 7f19591

Please sign in to comment.