Skip to content

Commit

Permalink
Fixes namespace (#606)
Browse files Browse the repository at this point in the history
Summary:
Fixes namespace so PHPStorm doesn't throw warnings about wrong expected type

<img width="674" alt="Screenshot 2024-07-24 at 3 38 36 PM" src="https://github.com/user-attachments/assets/d9141cc1-04d1-426f-a9f9-a393747565be">

<img width="1186" alt="Screenshot 2024-07-24 at 3 40 13 PM" src="https://github.com/user-attachments/assets/45f0f2ac-8e59-4ffd-8841-84a88c8f401e">

Pull Request resolved: #606

Reviewed By: liliarizona

Differential Revision: D61413277

Pulled By: stcheng

fbshipit-source-id: 14d15ceaca2bd6f7a6e29046424723e5ceb4e90b
  • Loading branch information
geoffreyrose authored and facebook-github-bot committed Aug 16, 2024
1 parent 381d100 commit ba5771d
Show file tree
Hide file tree
Showing 9 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions src/FacebookAds/Object/BusinessDataAPI/Event.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public function setEventId($event_id) {

/**
* Sets UserData object that contains user data.
* @param FacebookAds\Object\BusinessDataAPI\UserData $user_data
* @param \FacebookAds\Object\BusinessDataAPI\UserData $user_data
* @return $this
*/
public function setUserData($user_data) {
Expand All @@ -92,7 +92,7 @@ public function setUserData($user_data) {

/**
* Sets CustomData object that includes additional business data about the event.
* @param FacebookAds\Object\BusinessDataAPI\CustomData $custom_data
* @param \FacebookAds\Object\BusinessDataAPI\CustomData $custom_data
* @return $this
*/
public function setCustomData($custom_data) {
Expand Down
2 changes: 1 addition & 1 deletion src/FacebookAds/Object/BusinessDataAPI/EventRequest.php
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public function __construct(string $page_id, array $data = null) {

/**
* Sets an array of Business Data Event objects
* @param FacebookAds\Object\BusinessDataAPI\Event[] $events An array of Business Data Event objects
* @param \FacebookAds\Object\BusinessDataAPI\Event[] $events An array of Business Data Event objects
* @return $this
*/
public function setEvents($events) {
Expand Down
8 changes: 4 additions & 4 deletions src/FacebookAds/Object/ServerSide/Event.php
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ public function setEventId($event_id) {

/**
* Sets UserData object that contains user data.
* @param FacebookAds\Object\ServerSide\UserData $user_data
* @param \FacebookAds\Object\ServerSide\UserData $user_data
* @return $this
*/
public function setUserData($user_data) {
Expand All @@ -279,7 +279,7 @@ public function setUserData($user_data) {

/**
* Sets CustomData object that includes additional business data about the event.
* @param FacebookAds\Object\ServerSide\CustomData $custom_data
* @param \FacebookAds\Object\ServerSide\CustomData $custom_data
* @return $this
*/
public function setCustomData($custom_data) {
Expand Down Expand Up @@ -473,15 +473,15 @@ public function getEventId() {

/**
* Gets UserData object that contains user data
* @return FacebookAds\Object\ServerSide\UserData
* @return \FacebookAds\Object\ServerSide\UserData
*/
public function getUserData() {
return $this->container['user_data'];
}

/**
* Gets customData object that includes additional business data about the event.
* @return FacebookAds\Object\ServerSide\CustomData
* @return \FacebookAds\Object\ServerSide\CustomData
*/
public function getCustomData() {
return $this->container['custom_data'];
Expand Down
2 changes: 1 addition & 1 deletion src/FacebookAds/Object/ServerSide/EventRequest.php
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public function valid() {

/**
* Sets an array of Server Event objects
* @param FacebookAds\Object\ServerSide\Event[] $events An array of Server Event objects
* @param \FacebookAds\Object\ServerSide\Event[] $events An array of Server Event objects
* @return $this
*/
public function setEvents($events) {
Expand Down
2 changes: 1 addition & 1 deletion src/FacebookAds/Object/ServerSide/HttpServiceInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
interface HttpServiceInterface {
/**
* @param string $url The graph API endpoint that will be requested
* @param FacebookAds\Object\ServerSide\HttpMethod $method The HTTP request method
* @param \FacebookAds\Object\ServerSide\HttpMethod $method The HTTP request method
* @param array $curl_options Contains curl options
* @param array $headers Contains HTTP request headers including User-Agent and Accept-Encoding
* @param array $params Contains request parameters including access_token, data, test_event_code, etc.
Expand Down
4 changes: 2 additions & 2 deletions src/FacebookAds/Object/ServerSide/UserData.php
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ public function setPhones($phones) {

/**
* Sets Gender, in lowercase. Either f or m.
* @param FacebookAds\Object\ServerSide\Gender $gender Gender, in lowercase. Either f or m.
* @param \FacebookAds\Object\ServerSide\Gender $gender Gender, in lowercase. Either f or m.
* @return $this
*/
public function setGender($gender) {
Expand All @@ -464,7 +464,7 @@ public function setGender($gender) {
/**
* Sets a list of Genders, in lowercase.
* <p>Example: array('f', 'm')
* @param FacebookAds\Object\ServerSide\Gender[] $genders A list of Genders, in lowercase.
* @param \FacebookAds\Object\ServerSide\Gender[] $genders A list of Genders, in lowercase.
* @return $this
*/
public function setGenders($genders) {
Expand Down
4 changes: 2 additions & 2 deletions src/FacebookAds/Object/Signal/Event.php
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public function setEventId($event_id) {

/**
* Sets UserData object that contains user data.
* @param FacebookAds\Object\Signal\UserData $user_data
* @param \FacebookAds\Object\Signal\UserData $user_data
* @return $this
*/
public function setUserData($user_data) {
Expand All @@ -111,7 +111,7 @@ public function setUserData($user_data) {

/**
* Sets CustomData object that includes additional business data about the event.
* @param FacebookAds\Object\Signal\CustomData $custom_data
* @param \FacebookAds\Object\Signal\CustomData $custom_data
* @return $this
*/
public function setCustomData($custom_data) {
Expand Down
2 changes: 1 addition & 1 deletion src/FacebookAds/Object/Signal/EventRequest.php
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public function __construct(string $pixel_id, string $page_id, array $data = nul

/**
* Sets an array of Signal Event objects
* @param FacebookAds\Object\Signal\Event[] $events An array of Signal Event objects
* @param \FacebookAds\Object\Signal\Event[] $events An array of Signal Event objects
* @return $this
*/
public function setEvents($events) {
Expand Down
2 changes: 1 addition & 1 deletion src/FacebookAds/Object/Signal/UserData.php
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public function setPhone($phone) {

/**
* Sets Gender, in lowercase. Either f or m.
* @param FacebookAds\Object\ServerSide\Gender $gender Gender, in lowercase. Either f or m.
* @param \FacebookAds\Object\ServerSide\Gender $gender Gender, in lowercase. Either f or m.
* @return $this
*/
public function setGender($gender) {
Expand Down

0 comments on commit ba5771d

Please sign in to comment.