Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: improve handling of non-extism pointer types in host_fn macro #60

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

cleanup: improve handling of non-extism pointer types in host_fn macro #60

wants to merge 1 commit into from

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Jul 18, 2024 •
edited
Loading

Currently host_fn only supports Extism pointer arguments, this PR updates host_fn to preserve Wasm-native arguments (i32, i64, f32, f64) when passed as arguments, or returned from a host function.

TODO:

  • Add some examples and make sure the macro translates the types correctly
  • Consider doing something similar for shared_fn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdickinson chrisdickinson Awaiting requested review from chrisdickinson chrisdickinson will be requested when the pull request is marked ready for review chrisdickinson is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zshipko