Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed extism module and added methods to get exported functions #79

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

clarkmcc
Copy link
Contributor

@clarkmcc clarkmcc commented Oct 5, 2024

This PR does a couple of things:

  • It exposes the extism module struct.
  • It adds methods to get any exported functions from the module.
  • It adds a struct to wrap the wazero function definition, allowing Extism to control the API, while also exposing some of the behaviors provided by wazero.
  • It removes the module.wasm bytes from the module struct. It was unused as far as I could tell and I don't see any reason (while it's unused at least) that we wouldn't want the GC to be able to garbage collect that slice, especially when we're dealing with large modules.

@nilslice
Copy link
Member

nilslice commented Oct 7, 2024

thank you! will review today

Copy link
Collaborator

@mhmd-azeez mhmd-azeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @clarkmcc, thanks for the PR, lgtm!

Copy link
Member

@nilslice nilslice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! will merge and cut a release asap

@nilslice nilslice merged commit bdb398e into extism:main Oct 7, 2024
3 checks passed
@clarkmcc
Copy link
Contributor Author

clarkmcc commented Oct 7, 2024

🙌 Thanks for the consideration and the reviews!

@clarkmcc clarkmcc deleted the 78-expose-extism-module branch October 7, 2024 15:48
@bhelx
Copy link
Contributor

bhelx commented Oct 7, 2024

Thank you for taking the time @clarkmcc :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants