cleanup: manifest improvements #42
Conversation
| @@ -217,6 +228,52 @@ type Manifest struct { | |||
| Timeout uint64 `json:"timeout_ms,omitempty"` | |||
| } | |||
|
|
|||
| type concreteManifest struct { | |||
There was a problem hiding this comment.
I haven't tested this, but we could potentially embed the Manifest struct into this one (with no field name) and add the Wasm []concreteWasm field to it.
This way they stay in sync and we avoid duplication. Totally may not work though.
There was a problem hiding this comment.
I did try that but got a weird stack overflow error
There was a problem hiding this comment.
haha hmm ok, we can always change it later if we want since it's all internal. not worth spending much time now just to avoid a tiny bit of tech debt 😅
There was a problem hiding this comment.
LGTM! No issue merging now but maybe @mhmd-azeez can take a peek at some point too that would be great.
| } | ||
|
|
||
| func (m *Manifest) UnmarshalJSON(data []byte) error { | ||
| tmp := concreteManifest{} |
There was a problem hiding this comment.
oh I think this is where the stack overflow happens since UnmarshalJSON gets called recursively when it encounters the embedded type
There was a problem hiding this comment.
(but I don't think there's a way around it?)
There was a problem hiding this comment.
Yeah, other than splitting all the Manifest fields out into another struct (which ruins the usability from Go) there doesn't seem to be a good way to re-use them. I will sleep on it though.
|
Thanks! I will leave it open and merge it tomorrow so he gets a chance to review. |
extism.Manifestusing theconcreteManifesttype (et me know if there is a nicer way to do this in Go)