Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leakyRelu feature as a part of Relu layer. #323

Closed
wants to merge 7 commits into from

Conversation

naveenjafer
Copy link
Contributor

This is in line with #322. Have implemented Leaky Relu as a parameterized option inbuilt within Relu. Use the optional parameter "alphaLeaky" to use it.

@svlandeg svlandeg added enhancement Feature requests and improvements feat / layers Weights layers, transforms, combinators, wrappers labels Mar 10, 2020
@honnibal
Copy link
Member

Thanks for the PR. I'm thinking about the best way to do this: I'm trying to decide whether we should have the parameter in the op or not.

I think I'd probably prefer a different op for the leaky vs non-leaky relu, instead of a parameter. This also makes the naming easier.

@honnibal
Copy link
Member

I do think I'd prefer to have this as a separate operation, instead of a parameter, so I'll close this. I'm sure your implementation will be helpful in adding a leaky relu op though, thanks again 👍

@honnibal honnibal closed this Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements feat / layers Weights layers, transforms, combinators, wrappers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants