Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new OS models: Zephyr and Yi #392

Draft
wants to merge 58 commits into
base: develop
Choose a base branch
from
Draft

Conversation

rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Dec 1, 2023

Description

Add support for OS/HF models:

Corresponding documentation PR

explosion/spaCy#13174

Types of change

New feature.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

# Conflicts:
#	spacy_llm/tasks/builtin_task.py
…for handling both types of tasks. Update tests.
# Conflicts:
#	spacy_llm/tests/tasks/test_rel.py
@rmitsch rmitsch changed the base branch from develop to feat/inf-doc-len December 1, 2023 14:50
@rmitsch rmitsch changed the title Add support for Zephyr and Yi Support for Zephyr and Yi Dec 1, 2023
@rmitsch rmitsch changed the title Support for Zephyr and Yi Support new OS models: Zephyr and Yi Dec 4, 2023
@rmitsch rmitsch marked this pull request as ready for review December 4, 2023 15:57
@rmitsch rmitsch added the Test GPU Run GPU tests label Dec 4, 2023
Base automatically changed from feat/inf-doc-len to develop December 11, 2023 14:27
spacy_llm/pipeline/llm.py Outdated Show resolved Hide resolved
@svlandeg svlandeg changed the base branch from develop to main December 11, 2023 18:47
@svlandeg svlandeg changed the base branch from main to develop December 11, 2023 18:48
spacy_llm/models/hf/yi.py Outdated Show resolved Hide resolved
Comment on lines -209 to +215
return Doc.from_docs(list(shards), ensure_whitespace=True)
with warnings.catch_warnings():
warnings.filterwarnings(
"ignore",
category=UserWarning,
message=".*Skipping .* while merging docs.",
)
return Doc.from_docs(list(shards), ensure_whitespace=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where this edit is coming from?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a drive-by because I noticed the warnings filter is missing here 🙃 I can move this into a separate PR, if you mind having it in here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all just a bit confusing with the huge (mostly unrelated) git history etc - I do in general appreciate more "atomic" PRs ;-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do in general appreciate more "atomic" PRs ;-)

I know 🫣

It's all just a bit confusing with the huge (mostly unrelated) git history etc

Yeah, I don't know why that's the case. The branches should all be updated.

@svlandeg
Copy link
Member

Looks like the GPU tests failed...

@rmitsch
Copy link
Collaborator Author

rmitsch commented Dec 13, 2023

Looks like the GPU tests failed...

I couldn't figure out why exactly the CI runner fails with cutlassF: no kernel found to launch!, but from what I've found it might be a GPU-based incompatibility. Regardless, I think that this is not an issue we have to fix right now. I propose moving forward and reevaluating this at a later point (at the latest if users face issues with Yi).

@svlandeg
Copy link
Member

Let's finish #428 first, then resolve the conflicts and finalize this one.

@svlandeg svlandeg marked this pull request as draft March 18, 2024 20:29
@svlandeg svlandeg deleted the branch develop May 17, 2024 08:59
@svlandeg svlandeg closed this May 17, 2024
@svlandeg
Copy link
Member

This was unintentionally closed when I reset the develop branch.

@svlandeg svlandeg reopened this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/model Feature: models feat/new New feature Test GPU Run GPU tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants