Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing errors with set_extenion methods #13613

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix typing errors with set_extenion methods #13613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a45a9f
Fix typing errors with set_extenion methods
mribbons Sep 2, 2024
2280454
change set_extension method argument to Callable[]
mribbons Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions spacy/tokens/doc.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ from .underscore import Underscore

DOCBIN_ALL_ATTRS: Tuple[str, ...]

class DocMethod(Protocol):
def __call__(self: Doc, *args: Any, **kwargs: Any) -> Any: ... # type: ignore[misc]

class Doc:
vocab: Vocab
mem: Pool
Expand All @@ -53,15 +50,15 @@ class Doc:
default: Optional[Any] = ...,
getter: Optional[Callable[[Doc], Any]] = ...,
setter: Optional[Callable[[Doc, Any], None]] = ...,
method: Optional[DocMethod] = ...,
method: Optional[Callable[[Doc, Any]]] = ...,
force: bool = ...,
) -> None: ...
@classmethod
def get_extension(
cls, name: str
) -> Tuple[
Optional[Any],
Optional[DocMethod],
Optional[Callable[[Doc, Any]]],
Optional[Callable[[Doc], Any]],
Optional[Callable[[Doc, Any], None]],
]: ...
Expand All @@ -72,7 +69,7 @@ class Doc:
cls, name: str
) -> Tuple[
Optional[Any],
Optional[DocMethod],
Optional[Callable[[Doc, Any]]],
Optional[Callable[[Doc], Any]],
Optional[Callable[[Doc, Any], None]],
]: ...
Expand Down
9 changes: 3 additions & 6 deletions spacy/tokens/span.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ from .doc import Doc
from .token import Token
from .underscore import Underscore

class SpanMethod(Protocol):
def __call__(self: Span, *args: Any, **kwargs: Any) -> Any: ... # type: ignore[misc]

class Span:
@classmethod
def set_extension(
Expand All @@ -19,15 +16,15 @@ class Span:
default: Optional[Any] = ...,
getter: Optional[Callable[[Span], Any]] = ...,
setter: Optional[Callable[[Span, Any], None]] = ...,
method: Optional[SpanMethod] = ...,
method: Optional[Callable[[Span, Any]]] = ...,
force: bool = ...,
) -> None: ...
@classmethod
def get_extension(
cls, name: str
) -> Tuple[
Optional[Any],
Optional[SpanMethod],
Optional[Callable[[Span, Any]]],
Optional[Callable[[Span], Any]],
Optional[Callable[[Span, Any], None]],
]: ...
Expand All @@ -38,7 +35,7 @@ class Span:
cls, name: str
) -> Tuple[
Optional[Any],
Optional[SpanMethod],
Optional[Callable[[Span, Any]]],
Optional[Callable[[Span], Any]],
Optional[Callable[[Span, Any], None]],
]: ...
Expand Down
9 changes: 3 additions & 6 deletions spacy/tokens/token.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ from .morphanalysis import MorphAnalysis
from .span import Span
from .underscore import Underscore

class TokenMethod(Protocol):
def __call__(self: Token, *args: Any, **kwargs: Any) -> Any: ... # type: ignore[misc]

class Token:
i: int
doc: Doc
Expand All @@ -23,15 +20,15 @@ class Token:
default: Optional[Any] = ...,
getter: Optional[Callable[[Token], Any]] = ...,
setter: Optional[Callable[[Token, Any], None]] = ...,
method: Optional[TokenMethod] = ...,
method: Optional[Callable[[Token, Any]]] = ...,
force: bool = ...,
) -> None: ...
@classmethod
def get_extension(
cls, name: str
) -> Tuple[
Optional[Any],
Optional[TokenMethod],
Optional[Callable[[Token, Any]]],
Optional[Callable[[Token], Any]],
Optional[Callable[[Token, Any], None]],
]: ...
Expand All @@ -42,7 +39,7 @@ class Token:
cls, name: str
) -> Tuple[
Optional[Any],
Optional[TokenMethod],
Optional[Callable[[Token, Any]]],
Optional[Callable[[Token], Any]],
Optional[Callable[[Token, Any], None]],
]: ...
Expand Down