Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v4 branch with latest from master #13490

Merged
merged 23 commits into from
May 14, 2024
Merged

Conversation

svlandeg
Copy link
Member

Description

Merge master into v4. Required a few additional fixes for the textcat functionality.

Types of change

maintenance

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

danieldk and others added 23 commits February 2, 2024 13:01
…ion#13249)

* TextCatParametricAttention.v1: set key transform dimensions

This is necessary for tok2vec implementations that initialize
lazily (e.g. curated transformers).

* Add lazily-initialized tok2vec to simulate transformers

Add a lazily-initialized tok2vec to the tests and test the current
textcat models with it.

Fix some additional issues found using this test.

* isort

* Add `test.` prefix to `LazyInitTok2Vec.v1`
Also warn when any worker exited with a non-zero exit code and modify
test to ensure that workers exit cleanly by default.
The 'direct' option in 'spacy download' is supposed to only download from our model releases repository. However, users were able to pass in a relative path, allowing download from arbitrary repositories. This meant that a service that sourced strings from user input and which used the direct option would allow users to install arbitrary packages.
* Update gputests.yml

* Update slowtests.yml
* fix type annotation in docs

* only restore entities after loss calculation

* restore entities of sample in initialization

* rename overfitting function

* fix EL scorer

* Relax test

* fix formatting

* Update spacy/pipeline/entity_linker.py

Co-authored-by: Raphael Mitsch <r.mitsch@outlook.com>

* rename to _ensure_ents

* further rename

* allow for scorer to be None

---------

Co-authored-by: Raphael Mitsch <r.mitsch@outlook.com>
* Remove hardcoded architecture setting

* update classifiers to include Python 3.12
* fix typos

* prettier formatting

---------

Co-authored-by: svlandeg <svlandeg@github.com>
* update gh actions

* pin typer upperbound to 1.0.0
@svlandeg svlandeg added the 🔜 v4.0 Related to upcoming v4.0 label May 14, 2024
@svlandeg svlandeg merged commit 818fdb5 into explosion:v4 May 14, 2024
7 checks passed
@svlandeg svlandeg deleted the feat/update_v4 branch May 14, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔜 v4.0 Related to upcoming v4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants