Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Language.pipe workers exit cleanly #13321

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

danieldk
Copy link
Contributor

Description

Also warn when any worker exited with a non-zero exit code and modify test to ensure that workers exit cleanly by default.

Types of change

Bugfix

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@danieldk danieldk added bug Bugs and behaviour differing from documentation feat / pipeline Feature: Processing pipeline and components labels Feb 12, 2024
Also warn when any worker exited with a non-zero exit code and modify
test to ensure that workers exit cleanly by default.
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@svlandeg svlandeg merged commit fdfdbcd into explosion:master Feb 12, 2024
13 checks passed
@danieldk danieldk deleted the bugfix/workers-exit-cleanly branch February 14, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and behaviour differing from documentation feat / pipeline Feature: Processing pipeline and components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants