Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roman numerals #78

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

BNAndras
Copy link
Member

@BNAndras BNAndras commented Aug 7, 2023

@ErikSchierboom, would it be okay to add you as an exercise author in the config.json? The example.arr is almost a word-for-word port of your F# example for this exercise.

@BNAndras BNAndras added x:size/tiny Tiny amount of work x:module/practice-exercise Work on Practice Exercises x:rep/tiny Tiny amount of reputation x:type/content Work on content (e.g. exercises, concepts) x:knowledge/none No existing Exercism knowledge required labels Aug 7, 2023
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mention it. You've created the pyret code so you're the author. No need to credit me with anything, I'm happy that my solution was helpful, but thanks for asking!

@BNAndras BNAndras merged commit b69146f into exercism:main Aug 7, 2023
2 checks passed
@BNAndras BNAndras deleted the add-roman-numerals branch August 7, 2023 17:02
@BNAndras BNAndras added x:rep/medium Medium amount of reputation and removed x:size/tiny Tiny amount of work x:rep/tiny Tiny amount of reputation labels Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:knowledge/none No existing Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/medium Medium amount of reputation x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants