Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeychainSwiftAccessOptions tweak for Objective-C #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lawmaestro
Copy link

Marked up KeychainSwiftAccessOptions with a @objc annotation and made an integer raw type so this enum can be used when bridging in Objective-C.

…d made an integer raw type so this enum can be used when bridging in Objective-C.
@evgenyneu
Copy link
Owner

Thanks for the pull request, but I can not accept it, unfortunately. I intended keychain-swift to be a pure Swift library, and try to avoid any references to objective-C. For people who still want to use it from Objective-C projects, there is a KeychainSwiftCBridge.swift file. Since it is not included with the library, this is a good place to add Objective-C-related code. Feel free to resubmit a pull request, if it works for you. Thanks 👍

@lawmaestro
Copy link
Author

Hi. So I'm using an adapted 'KeychainSwiftCBridge.swift' file which exposes the setter with KeychainSwiftAccessOptions. However in order to expose that I had to make the tweak in this PR. I hear what you're saying with regards to adding Objective-C references but it seems to fairly trivial thing to get hung up on. Still, it's your call :)

@evgenyneu
Copy link
Owner

I'm sorry about that. I hope you find a good objective-c friendly alternative. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants