Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AccessControl support to KeychainSwift #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bakhshaei
Copy link

No description provided.

@bakhshaei
Copy link
Author

Hello,
In this PR, KeyhainSwift now support SecAccessControlCreateFlags, which is described here.
A best practice of this feature is described

Best Practice: Apple recommends using this feature to securely store items in the keychain and ensure they are only accessible when the user is present. Detailed guidance can be found here in Apple documentation.

Summary

  • ✅ Tests wrote for this added feature and all tests passed.
  • ✅ In Demo application (for iOS) some changes happen to optionally use this feature. (using a UISwitch)

I have personally used this feature in various projects for years and thought it would be beneficial to contribute it here. I hope you find this addition useful and valuable for the community. ❤️

@evgenyneu
Copy link
Owner

Thanks for your work, but I'm not accepting new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants