feat(no-callback-in-promise): add timeoutsErr option
#514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 26 +1
Lines 649 711 +62
Branches 250 277 +27
=========================================
+ Hits 649 711 +62 ☔ View full report in Codecov by Sentry. |
brettz9
force-pushed
the
no-callback-in-promise-timeouts
branch
from
0e80f70
to
e0453c4
Compare
brettz9
force-pushed
the
no-callback-in-promise-timeouts
branch
from
e0453c4
to
6b3dce6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…t-community#167 Also: - fix(`no-callback-in-promise`): ensure timeouts do not err (by default); fixes eslint-community#220
brettz9
force-pushed
the
no-callback-in-promise-timeouts
branch
from
6b3dce6
to
cee71eb
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (Give an overview)
no-callback-in-promise): addtimeoutsErroption; fixes no-callback-in-promise misses callback passed as argument #167no-callback-in-promise): ensure timeouts do not err (by default); fixes no-callback-in-promise use cases #220